feat: add prompt option #189
Conversation
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 88.54% 84.28% -4.26%
==========================================
Files 3 3
Lines 192 210 +18
Branches 39 43 +4
==========================================
+ Hits 170 177 +7
- Misses 20 29 +9
- Partials 2 4 +2
Continue to review full report at Codecov.
|
src/installer.js
Outdated
| peerDependencies: true, | ||
| quiet: false, | ||
| // flip to true | ||
| prompt: false, |
There was a problem hiding this comment.
Let's do it true by default
src/installer.js
Outdated
|
|
||
| const { green, yellow } = require('colorette'); | ||
|
|
||
| const prompt = require('./utils/prompt'); |
There was a problem hiding this comment.
I think he means, using it as this.prompt instead of creating separate util and importing.
There was a problem hiding this comment.
we don't have access to plugin class in the installer so I've inlined the util in installer instead
|
/cc @snitin315 |
|
@snitin315 @anshumanv next job #94 - we should avoid using |
|
On it 👍 |
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
yet to
If relevant, did you update the documentation?
yet to
Summary
Adds a prompt option to allow users to prevent auto installation
Does this PR introduce a breaking change?
no
Other information
wip on some fixes and tests