Inconsistency between system scalar type serialize/parseValue methods

[mcg-web]

Hi, after upgrading my project from 0.10 to 0.11 version I get some weird behaviors with system scalar types when using inputs with variables. I don't really get why we have a differents between serialize/parseValue methods.
Here an example IntType::parseValue no more accepts string but IntType::serialize does:

(new IntType())->serialize('9') !== (new IntType())->parseValue('9'); // 9 !== null

In JS implementation both methods has the same behavior so why in PHP we add these differents?
I override system scalar types to use 0.10 version right now but this is not the best solution... I'm just trying to understand the reason why...

How I override system scalar types without using reflection:

// Override scalar types
$overrideScalarTypes = \Closure::bind(function () {
    self::$internalTypes = [
        self::ID => new MyType\IDType(),
        self::STRING => new MyType\StringType(),
        self::FLOAT => new MyType\FloatType(),
        self::INT => new MyType\IntType(),
        self::BOOLEAN => new MyType\BooleanType()
    ];
}, null, \GraphQL\Type\Definition\Type::class);
$overrideScalarTypes();

This can maybe helps some people encountering same issue.

[vladar]

As far as I remember it was done in #170. It was actually a valid issue (at least for strings and booleans). A related issue in graphql-js - graphql/graphql-js#771 (yet they seem to fix only string case, not boolean or int).

So do you need to accept strings as integer input?

[mcg-web]

My trouble is that string is no more accepted as int also int is not accepted as string in parseValue method but with serialize both works. I can submit a PR that show what I'm waiting for if you want?

[vladar]

Sorry for the long delay with a response, I suggest to send a PR after I merge #248 (hopefully on this weekend)

[danez]

This problem should be fixed in #248 as the serialize and parseValue methods have been aligned together. https://github.com/danez/graphql-php/blob/3e067cc60fb720703453904f1351f3acbfb4b453/src/Type/Definition/IntType.php#L39..L52

[mcg-web]

Nice! Thank you @danez 👍 .

[vladar]

@mcg-web Can you check if the new version (in master) works for you and close if it is OK?

[mcg-web]

It seems to be OK! Thank you @vladar and @danez 👍