Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Conversation

@luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Aug 23, 2024

Description

[4.12.1]

Fixed

web3-eth-accounts

  • Revert TransactionFactory.registerTransactionType if there is a version mistatch between web3-eth and web3-eth-accounts and fix nextjs problem. (Fix nextjs problem #7216)

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@github-actions
Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.17 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 619.88 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 4de0bd1 Previous: 0b75589 Ratio
processingTx 23035 ops/sec (±7.88%) 21778 ops/sec (±6.02%) 0.95
processingContractDeploy 40603 ops/sec (±8.23%) 37125 ops/sec (±6.62%) 0.91
processingContractMethodSend 16696 ops/sec (±7.89%) 14868 ops/sec (±10.20%) 0.89
processingContractMethodCall 27879 ops/sec (±8.29%) 27609 ops/sec (±6.05%) 0.99
abiEncode 46688 ops/sec (±6.96%) 40195 ops/sec (±8.19%) 0.86
abiDecode 30766 ops/sec (±7.87%) 27790 ops/sec (±7.70%) 0.90
sign 1608 ops/sec (±0.81%) 1546 ops/sec (±0.83%) 0.96
verify 367 ops/sec (±2.71%) 363 ops/sec (±2.56%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Benchmark

Benchmark suite Current: 4de0bd1 Previous: 0b75589 Ratio
processingTx 22737 ops/sec (±9.17%) 21778 ops/sec (±6.02%) 0.96
processingContractDeploy 39725 ops/sec (±7.51%) 37125 ops/sec (±6.62%) 0.93
processingContractMethodSend 16364 ops/sec (±7.04%) 14868 ops/sec (±10.20%) 0.91
processingContractMethodCall 27327 ops/sec (±7.25%) 27609 ops/sec (±6.05%) 1.01
abiEncode 43881 ops/sec (±7.30%) 40195 ops/sec (±8.19%) 0.92
abiDecode 31347 ops/sec (±6.35%) 27790 ops/sec (±7.70%) 0.89
sign 1514 ops/sec (±3.34%) 1546 ops/sec (±0.83%) 1.02
verify 366 ops/sec (±0.54%) 363 ops/sec (±2.56%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@cloudflare-workers-and-pages
Copy link

Deploying web3-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4de0bd1
Status: ✅  Deploy successful!
Preview URL: https://a06c8908.web3-js-docs.pages.dev
Branch Preview URL: https://head.web3-js-docs.pages.dev

View logs

@@ -1,6 +1,6 @@
{
"name": "web3",
"version": "4.12.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luu-alex plus also include web3-types package in this release

@codecov
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (0b75589) to head (4de0bd1).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7217   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         216      216           
  Lines        8429     8429           
  Branches     2315     2315           
=======================================
  Hits         7966     7966           
  Misses        463      463           
Flag Coverage Δ
UnitTests 94.50% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex luu-alex merged commit f351e00 into 4.x Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants