Skip to content

feat(module-tools): improve svg typing for SVGR #5422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2024
Merged

feat(module-tools): improve svg typing for SVGR #5422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6de34e6
feat(module-tools): improve svg typing for SVGR
chenjiahan Feb 21, 2024
624f2ad
chore: upd
chenjiahan Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/tough-icons-help.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@modern-js/module-tools': patch
---

feat(module-tools): improve svg typing for SVGR

feat(module-tools): 优化 svg 类型定义
14 changes: 12 additions & 2 deletions packages/solutions/module-tools/lib/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,18 @@ declare module '*.webp' {
}

declare module '*.svg' {
const src: string;
export default src;
import * as React from 'react';

export const ReactComponent: React.FunctionComponent<
React.SVGProps<SVGSVGElement>
>;

/**
* The default export type depends on the asset.svgr.exportType config,
* it can be a string or a ReactComponent
* */
const content: any;
export default content;
}

declare module '*.css' {
Expand Down