Skip to content

fix(builder): should not print file size of LICENSE.text #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023
Merged

fix(builder): should not print file size of LICENSE.text #3746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/gold-dingos-occur.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@modern-js/builder': patch
---

fix(builder): should not print file size of LICENSE.text

fix(builder): 打印文件体积时忽略 LICENSE.text
5 changes: 3 additions & 2 deletions packages/builder/builder/src/plugins/fileSize.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ import {
} from '@modern-js/builder-shared';
import type { DefaultBuilderPlugin } from '@modern-js/builder-shared';

/** Filter source map files */
export const filterAsset = (asset: string) => !/\.map$/.test(asset);
/** Filter source map and license files */
export const filterAsset = (asset: string) =>
!/\.map$/.test(asset) && !/\.LICENSE\.txt$/.test(asset);

const getAssetColor = (size: number) => {
if (size > 300 * 1000) {
Expand Down
2 changes: 2 additions & 0 deletions packages/builder/builder/tests/plugins/fileSize.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ describe('plugins/fileSize', () => {
expect(filterAsset('dist/a.css')).toBeTruthy();
expect(filterAsset('dist/a.js.map')).toBeFalsy();
expect(filterAsset('dist/b.css.map')).toBeFalsy();
expect(filterAsset('dist/a.js.LICENSE.txt')).toBeFalsy();
expect(filterAsset('dist/b.css.LICENSE.txt')).toBeFalsy();
expect(filterAsset('dist/a.png')).toBeTruthy();
});
});