Component object fingerprint value #8
Conversation
weaverryan
force-pushed
the
component-object-fingerprint-value
branch
from
36f146c to
e49933a
Compare
weaverryan
changed the title
weaverryan
changed the title
weaverryan
changed the title
|
|
||
| public function calculateFingerprint(array $data): string | ||
| { | ||
| return base64_encode(hash_hmac('sha256', serialize($data), $this->secret, true)); |
There was a problem hiding this comment.
This is all internal so we can change later but maybe we should create a ChecksumCalculator object that's used for calculating the checksum and the fingerprint?
In a future PR, will you need to verify the fingerprint?
There was a problem hiding this comment.
I'm going to save for later, but you're right.
Related, it's odd to have to pass the $secret into DehydratedComponent. Probably there should be a DehydratedComponentFactory and some of the DehydratedComponent logic (i.e. public static function createFromCombinedData and the checksum creation) should be moved there.
There was a problem hiding this comment.
Yeah, a new ChecksumCalculator would contain the secret - once we have this service, it will probably require some refactoring of DehydratedComponent.
|
Merged in now - thanks for the review :) |
symfony#500
The reason for this is explained by the same flow:
A) Component parent renders & all children are given a "fingerprint" (this PR!) that is a checksum of the "input" passed to create that child
B) On parent re-render, an array containing [{ id: 'the-child-id', fingerprint: 'its fingerprint'}, ... ] is sent along with the parent component data.
C) We will (still a TODO - 6 on the linked PR) use that info to figure out if the "fingerprint" of any specific children has changed (i.e. we calculate the deterministic id of a child component, find its fingerprint using that id from the data above, and compare).