Skip to content
This repository was archived by the owner on Mar 21, 2024. It is now read-only.

Conversation

jamienutter
Copy link
Collaborator

Removed the scripts and made them modules.
Tidied the code and added a bunch of #TODO items throughout.

@jamienutter jamienutter requested a review from a team as a code owner October 5, 2023 10:22
Copy link

@dtpryce dtpryce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you have planned out stuff for others to do via todos. My only comment that doesn't block merging, it might be worth keeping that old README somewhere so you can understand those scripts / class usage until it's ready to be fully updated. I guess it's here in history and in old fork but just a thought.

@jamienutter
Copy link
Collaborator Author

I like how you have planned out stuff for others to do via todos. My only comment that doesn't block merging, it might be worth keeping that old README somewhere so you can understand those scripts / class usage until it's ready to be fully updated. I guess it's here in history and in old fork but just a thought.

I've removed the scripts so I also removed from the README as it no longer correlates.
The scripts and old README are in history and the original code too

@jamienutter jamienutter merged commit 50fe6fc into master Oct 5, 2023
@jamienutter jamienutter deleted the AEGIS-6406-fix-scripts branch October 5, 2023 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants