This repository was archived by the owner on Mar 21, 2024. It is now read-only.
AEGIS-6405 pass magic bytes as variable #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magic bytes as variable so that it is usable for other OS/file formats
jamienutter
suggested changes
Oct 3, 2023
asm2vec/binary_to_asm.py
Outdated
| :param minlen_upper: The minimum number of assembly functions needed for disassembling | ||
| :param minlen_lower: If disassembling not possible with with minlen_upper, lower the minimum number | ||
| of assembly functions to minlen_lower | ||
| :param magic_bytes for the specific OS/type of binary |
There was a problem hiding this comment.
What is the default and to which OS does it link?
There was a problem hiding this comment.
The default values correspond to MacOS - added a list of valid magic bytes
If none, then use the magic bytes for MacOS
jamienutter
approved these changes
Oct 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magic bytes as variable so that it is usable for other OS/file formats