This repository was archived by the owner on Mar 21, 2024. It is now read-only.
Aegis 6405 asm2vec pytorch edits #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/bin2asm.py to be replaced with asm2vec/binary_to_asm.py
jamienutter
suggested changes
Oct 2, 2023
asm2vec/binary_to_asm.py
Outdated
Comment on lines
11
to
17
| def __init__(self, input_path: str, output_path: str) -> None: | ||
| """Disassembles the newly collected malware files | ||
| :param input_path: the path to the malware binaries | ||
| :param output_path: the path for the assembly functions to be extracted | ||
| """ | ||
| self.binary_dir = Path(input_path) | ||
| self.asm_dir = Path(output_path) |
There was a problem hiding this comment.
Can we simplify this?
The paths are only used in one method.
Therefore to keep generic and reuasable, lets not have a class. Just functions.
And pass the paths into the one function that needs them
Co-authored-by: Jamie Nutter <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEP8, replaced scripts/bin2asm.py with asm2vec/binary_to_asm.py