Skip to content

Conversation

@FlorianFranzen
Copy link
Contributor

@FlorianFranzen FlorianFranzen commented Sep 10, 2020

I noticed we actually do not check the value returned by ext_storage_read_version_1, this PR fixes that. As a result we also learned that each implementation kind of does their own thing, so before this can be merged upstream will have to fix their implementations. Because I had to update substrate to the latest version for the fix, I was also required updates to the new child storage API.

List of changes

@FlorianFranzen FlorianFranzen self-assigned this Sep 10, 2020
@FlorianFranzen FlorianFranzen force-pushed the test/host-api/wasm/check-return-storage-read branch from 274ac87 to e901355 Compare September 10, 2020 17:08
@FlorianFranzen FlorianFranzen force-pushed the test/host-api/wasm/check-return-storage-read branch from e901355 to 1938b4f Compare September 11, 2020 13:14
@FlorianFranzen FlorianFranzen force-pushed the test/host-api/wasm/check-return-storage-read branch 2 times, most recently from 141ec97 to eef39e5 Compare September 20, 2020 22:33
@FlorianFranzen FlorianFranzen force-pushed the test/host-api/wasm/check-return-storage-read branch from a491519 to 0865ba7 Compare September 21, 2020 20:20
@FlorianFranzen FlorianFranzen added the specification Additions and Updates to the Specification label Sep 21, 2020
@FlorianFranzen FlorianFranzen marked this pull request as ready for review September 21, 2020 20:25
@FlorianFranzen FlorianFranzen force-pushed the test/host-api/wasm/check-return-storage-read branch from 0865ba7 to de311af Compare September 21, 2020 20:55
@FlorianFranzen FlorianFranzen changed the title wasm-adapter: check storage read return value wasm-adapter: check storage_read return value and update to default_child_storage Sep 21, 2020
@FlorianFranzen FlorianFranzen merged commit 11673b3 into master Sep 22, 2020
@FlorianFranzen FlorianFranzen deleted the test/host-api/wasm/check-return-storage-read branch September 22, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

specification Additions and Updates to the Specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants