wasm-adapter: check storage_read return value and update to default_child_storage #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed we actually do not check the value returned by
ext_storage_read_version_1, this PR fixes that. As a result we also learned that each implementation kind of does their own thing, so before this can be merged upstream will have to fix their implementations. Because I had to update substrate to the latest version for the fix, I was also required updates to the new child storage API.List of changes
ext_storage_readreturn value in wasm-adapter (4c2b00f)storage::readparitytech/substrate#7084)..._storage_child_...to..._default_child_storage_...API