feat: parse SharedArrayBuffer and validate AllowShared #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (this.idlType === "BufferSource") { | ||
| // XXX: For now this is a hack. Consider moving parents' extAttrs into types as the spec says: | ||
| // https://webidl.spec.whatwg.org/#idl-annotated-types | ||
| for (const extAttrs of [this.extAttrs, this.parent?.extAttrs]) { |
Member
There was a problem hiding this comment.
Could this be [this.extAttrs, this.parent?.extAttrs].flat() to avoid the second for loop?
Member
There was a problem hiding this comment.
yeah, maybe also... to flatten to code a little more:
for (const extAttr of [this.extAttrs, this.parent?.extAttrs].flat()) {
if (extAttr.name !== "AllowShared") continue;
// the rest...
}
Member
Author
There was a problem hiding this comment.
That way the autofix won't know which array includes the attr and it'll need to rescan 😬
pyoor
added a commit
to pyoor/gecko-webidl
that referenced
this pull request
Jul 5, 2023
Since w3c/webidl2.js#747, webidl2 treats SharedArrayBuffer as an inline type which breaks parsing of gecko IDLs.
saschanaz
pushed a commit
to mozilla/gecko-webidl
that referenced
this pull request
Jul 11, 2023
Since w3c/webidl2.js#747, webidl2 treats SharedArrayBuffer as an inline type which breaks parsing of gecko IDLs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch closes #746 and includes: