Add a way of specifying blockSize and compressLevel to FLAC encod… #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrtc
changed the title
dalecurtis
approved these changes
Dec 9, 2022
Contributor
Author
chrisn
requested changes
Dec 12, 2022
Contributor
Author
|
Do any reviewers have further comments here ? |
Contributor
I have none. Works for me. |
Contributor
|
@chrisn did you want to stamp and merge? |
Member
|
There's just one change remaining, I suggest removing the |
Contributor
Author
done, update FLAC reference to IETF draft. @chrisn |
chrisn
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds blockSize, compressLevel configuration knobs to the FLAC encoder.
This should fix #595 ,
@Yahweasel @dalecurtis