Allow nulls in VideoColorSpaceInit #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2022 13:46
padenot
approved these changes
Oct 12, 2022
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
SHA: 9ad546a Reason: push, by dalecurtis Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #561
This change allows
VideoColorSpaceInitdictionary values to benull, which allowsVideoColorSpaceto be used in place of aVideoColorSpaceInitas was always intended.The alternative fix is to allow the values to be
undefined, and that would be preferable except that it is not backwards-compatible.Surprisingly no changes to the algorithms are required, they already behave correctly when
nullis passed.Preview | Diff