Define AudioDataCopyToOptions with frameOffset and frameCount #228
Conversation
|
+1 to adding the sample format to the copyTo options or also having a convertTo(format, options). These are all easy to convert, but as an implementation quality issue a NotSupportedError could be thrown if an implementation doesn't support it for now. |
index.src.html
Outdated
| |options|.{{AudioDataCopyToOptions/planeIndex}}. | ||
|
|
||
| NOTE: For interleaved formats with a single plane, |frameCount| will | ||
| be the total number of frames accross all channels. |
There was a problem hiding this comment.
It's the sample count then, if it's across all channels. A frame count is specifically channel-count independent.
This steps should be about finding a number of elements to copy, based on the various parameters passed as parameter. Then the caller simply copies.
There was a problem hiding this comment.
Thanks, hopefully fixed! Algo now returns number of elements, including multiplication by channel count for interleaved formats.
index.src.html
Outdated
| |options|.{{AudioDataCopyToOptions/planeIndex}}. | ||
|
|
||
| NOTE: For interleaved formats with a single plane, |frameCount| will | ||
| be the total number of frames accross all channels. |
There was a problem hiding this comment.
Thanks, hopefully fixed! Algo now returns number of elements, including multiplication by channel count for interleaved formats.
|
Looks good, thanks! Can you rebase it so I can rebase #256 and merge it? |
|
Editors call: @aboba says LGTM |
|
Thanks! Rebased and proceeding to merge. |
SHA: 0db2aae Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 0db2aae Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 0db2aae Reason: push, by @chcunningham Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 0db2aae Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 0db2aae Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 0db2aae Reason: push, by @tguilbert-google Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Following up on this TODO
https://github.com/w3c/webcodecs/pull/162/files#r625845109
Fixes #179
Fixes #223
Preview | Diff