Skip to content

visibleRect validation for VideoFrame{Buffer}Init seems wrong #515

@ChunMinChang

Description

@ChunMinChang

Validate VideoFrameInit and Validate VideoFrameBufferInit return false when visibleRect.y + visibleRect.height >= codedHeight in step 1-5 and step 3 respectively, or visibleRect.x + visibleRect.width >= codedWidth in step 1-6 and step 4 respectively, while Parse Visible Rect returns false when overrideRect.y + overrideRect.height > codedHeight or overrideRect.x + overrideRect.width > codedWidth. Shouldn’t Validate VideoFrameInit and Validate VideoFrameBufferInit return false in the “>” case instead of “>=”? A VideoFrame{Buffer}Init value with a visibleRect whose (x, y, width, height) = (0, 0, 2, 2), codedWidth=2 and codedHeight=2 seems valid.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions