Skip to content

Generate html files at build time #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

tenzap
Copy link
Contributor

@tenzap tenzap commented Jun 29, 2025

No description provided.

Copy link
Member

@ylafon ylafon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't review the already existing html files, it is fine to create new ones when building the war file, but regenerating every time a build is done would trigger unnecessary changes due do the last-modified time change.

@tenzap
Copy link
Contributor Author

tenzap commented Jul 7, 2025

The MR creates the html only when making the war, not when building the classes. Unless I didn't understand what you meant.

@ylafon
Copy link
Member

ylafon commented Jul 7, 2025

Yes but it deletes all the .html

@tenzap
Copy link
Contributor Author

tenzap commented Jul 7, 2025

When are they needed? From what I understood, they are needed

  • for the war
  • for jigsaw, but in that case the servlet creates them only once if they don't exist. Is this a problem?

@ylafon
Copy link
Member

ylafon commented Jul 8, 2025

close per #457

@ylafon ylafon closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants