Infrastructure: Fix regression test menu-button_links.js to wait for url change #1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like this passed the CI checks. After review, I suggest merging this and then rebasing #1888 |
jesdaigle
approved these changes
May 25, 2021
Contributor
Author
|
@mcking65 can you merge this, please? |
mcking65
added
bug
mcking65
changed the title
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1888 the regression test
menu-button_links.jsis repeatedly failing in CI, but I could not reproduce locally. Maybe it's a race condition? Here's an attempt at a fix, to see if it makes the test pass in CI.