Skip to content

Infrastructure: Make 'npm run regression' run as headless by default #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Infrastructure: Make 'npm run regression' run as headless by default #1888

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b8e782
Make 'npm run regression' run as headless by default
zcorpan May 5, 2021
df21831
Add a console message when running npm run regression to inform about…
zcorpan May 20, 2021
4ee5298
Revert "Add a console message when running npm run regression to info…
zcorpan May 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const queryElement = require('./util/queryElement');
const queryElements = require('./util/queryElements');

let session, geckodriver;
const firefoxArgs = process.env.CI ? ['-headless'] : [];
const firefoxArgs = process.env.DEBUG ? [] : ['-headless'];
Copy link
Contributor

@nschonni nschonni Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Should this get documented somewhere, or is that already done on the wiki?

Copy link
Contributor Author

@zcorpan zcorpan Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not documented yet, but the OP says to change the wiki when merging.

(I think it would be better to have the documentation in the tree, so PRs like this one can update the documentation in the PR, and people can review the documentation changes...)

Copy link
Contributor

@nschonni nschonni Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, it would be flipping the current instructions around CI=1 npm run regression

const testWaitTime = parseInt(process.env.TEST_WAIT_TIME) || 500;
const coverageReportRun = process.env.REGRESSION_COVERAGE_REPORT;

Expand Down