Skip to content

Adopt ECMAScript modules #2671

@a11ydoer

Description

@a11ydoer

In terms of the code review, i worked with @alflennik to derive the following:

  • validated that that the addition of listitem.scrollIntoView({ block: 'nearest', inline: 'nearest' is working
  • validated that the addition of the eslint-disable-line comments did in fact eliminate the lint error (although, there are notes on this below)

It is important to note that even though disabling the error did disable the error, it did not address the error in and of itself, and therefore cannot be a resolution to the issue at hand.

Thankfully @jugglinmike has created a PR that addresses the eslint errors. It can be found here: #2642

A more in-depth explanation is provided in the PR itself, but to provide a summary here:

Because of existing code sharing logic in the project, any iterations away from the existing logic will conflict with the current setup.

It makes sense to apply these changes in a PR separate from this one to address this holistically in the project and not just on this pattern in particular. Therefore keeping the logic the same for this patch.

If you are in alignment with the above, we can go ahead and merge it in for you :)

Originally posted by @aleenaloves in #2622 (comment)

Metadata

Metadata

Assignees

Labels

Code QualityNon-functional code changes to satisfy APG code style guidelines and lintersenhancementAny addition or improvement that doesn't fix a code bug or prose inaccuracyjavascriptPull requests that update Javascript code

Type

No type

Projects

Status

In production / Completed

Relationships

None yet

Development

No branches or pull requests

Issue actions