perf: prevent loading all main images on the mobile PDP gallery #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
commented
May 12, 2022
| } | ||
| } | ||
| .sf-gallery { |
Collaborator
Author
There was a problem hiding this comment.
Well, basically, all gallery images are lazyloaded, on the mobile, all were in the viewport, now only the first one will be so the rest will be not loaded instantly.
bartoszherba
force-pushed
the
M2-578-do-not-load-main-images-assets-instantly-on-the-mobile
branch
from
9a45ec1 to
0fe9e0a
Compare
sethidden
approved these changes
May 12, 2022
bartoszherba
deleted the
M2-578-do-not-load-main-images-assets-instantly-on-the-mobile
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
perf: prevent loading all main images on the mobile PDP gallery
Types of changes
Checklist: