Skip to content

perf: make read reviews loaded on request #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2022
Merged

perf: make read reviews loaded on request #982

merged 1 commit into from
May 12, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented May 12, 2022 •
edited
Loading

Description

  • change loading revies behavior, now will be loaded on explicit action

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

sethidden
sethidden requested changes May 12, 2022
View reviewed changes
@bartoszherba
perf: make read reviews loaded on request
c359197 
- change loading revies behavior, now will be loaden on explicit action

M2-519
@bartoszherba bartoszherba force-pushed the M2-519-make-read-reviews-section-lazy-loaded branch from 7b16afe to c359197 Compare May 12, 2022 09:02
@bartoszherba bartoszherba requested a review from sethidden May 12, 2022 09:03
sethidden
sethidden approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@sethidden sethidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bartoszherba bartoszherba merged commit 49044df into develop May 12, 2022
@bartoszherba bartoszherba deleted the M2-519-make-read-reviews-section-lazy-loaded branch May 12, 2022 09:04
@Frodigo Frodigo added this to the 1.0.0-rc.8 milestone May 23, 2022
@Frodigo Frodigo mentioned this pull request May 26, 2022
Merged
@Frodigo Frodigo mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethidden sethidden sethidden approved these changes

@Frodigo Frodigo Awaiting requested review from Frodigo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.8

Development

Successfully merging this pull request may close these issues.

4 participants

@bartoszherba @sethidden @Frodigo