perf: make related and upsell products lazy loaded when visible #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
force-pushed
the
M2-517-make-related-upsell-products-lazy-loaded-when-visible
branch
from
5f89fdd to
5a9a1f4
Compare
sethidden
approved these changes
May 11, 2022
Contributor
sethidden
left a comment
sethidden
left a comment
There was a problem hiding this comment.
left optional comment, lgtm
| <LazyHydrate | ||
| when-visible | ||
| > | ||
| <LoadWhenVisible> |
Contributor
There was a problem hiding this comment.
Not sure if it's worth being this granular. Would putting related and upsell in one LoadWhenVisible makes sense? That way it'd be "if you move down to the additional sections, the additional sections are loaded)
bartoszherba
deleted the
M2-517-make-related-upsell-products-lazy-loaded-when-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make related and upsell products lazy loaded when visible
Types of changes
Checklist: