refactor!: components for product list/grid #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
force-pushed
the
M2-447-create-grid-list-components
branch
3 times, most recently
from
2922093 to
12768bd
Compare
sethidden
commented
Apr 24, 2022
sethidden
force-pushed
the
M2-447-create-grid-list-components
branch
4 times, most recently
from
e6c2a74 to
98fa7c5
Compare
sethidden
commented
Apr 25, 2022
sethidden
force-pushed
the
M2-447-create-grid-list-components
branch
2 times, most recently
from
c63a33b to
903fc0e
Compare
sethidden
commented
Apr 25, 2022
| /** | ||
| * Parameters accepted by the `isInCart` method in the {@link useCart} composable | ||
| */ | ||
| type UseCartIsInCartParams<CART, PRODUCT> = { |
Contributor
Author
There was a problem hiding this comment.
The types did not match the implementation here. The cart argument is no longer necessary
sethidden
force-pushed
the
M2-447-create-grid-list-components
branch
5 times, most recently
from
c794689 to
df61a39
Compare
M2-447 refactor: split product list and grid components refactor: move common props to composition function fix: paths fix: don't show empty when isShowProducts = false fix: don't set width on skeletons fix: wishlist icons appearing when not supposed to fix: can't add to cart in grid view refactor: squash this
sethidden
force-pushed
the
M2-447-create-grid-list-components
branch
from
df61a39 to
50003ff
Compare
Frodigo
approved these changes
Apr 26, 2022
Contributor
Author
|
now we wait for the speedcurve results 👀 |
Frodigo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the category page (category.vue)'s product grid and list views were inlined in the category.vue template.
After this PR, both list and grid components are separate. This means the category.vue template is a bit smaller now.
Acceptance criteria