fix: remove commitizen prepare-commit-msg git hook #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Screen.Recording.2022-03-23.at.14.41.30.mova |
bloodf
previously approved these changes
Mar 23, 2022
Contributor
|
I'm also in favor of removing this hook, or maybe finding a way of making it optional. If people don't run Anyway, commitizen doesn't actually guarantee good commit messages, commitlint does that, so the hook is more of a "cosmetic" feature. |
Contributor
Author
|
Yeah I was thinking about removing this hook, but keeping |
Contributor
|
I am either voting for removing that pre-commit hook and as you mentioned @sethidden - keeping |
before this commit running git commit ran commitizen instead of showing the traditional git commit message prompt doing that was too much of an intrusion into the workflow so we've decided to keep cz, but make it optional to use instead of required
sethidden
force-pushed
the
M2-343-fix-husky-pre-commit-hook
branch
from
24619bf to
66ca107
Compare
sethidden
changed the title
Frodigo
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STOP - Actually check out to the branch, run "yarn" and see if commiting to the branch the way you usually do it (maybe from within IDE? maybe terminal?) behaves to your liking
We have a git hook that launches when you type
git commit, the problem up until now is that it just errored out during launch, so it didn't change the way git commit works originally. Here I'm fixing it so it works as intended by the original author of the commit that added it.But I suspect that the sudden change of how
git commitworks may break the workflows of contributors and devs who commit outside the terminal. Basically, please check out to this branch and try to commit something the way you usually do it and see if that isn't annoying. You can commit from inside Webstorm, using the terminal, or from Vim (like I do and where this PR breaks things, so I'll have to commit from the terminal if this is merged)I'm super open to removing this hook altogether