Skip to content

fix(homepage): fixed new products carousel ssr rendering issues #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2022
Merged

fix(homepage): fixed new products carousel ssr rendering issues #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions packages/theme/pages/Home.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,17 +97,17 @@ import {
SfCallToAction,
SfBannerGrid,
} from '@storefront-ui/vue';
import { productGetters } from '~/getters';

import {
computed,
defineComponent,
ref,
useContext,
useFetch,
useAsync,
} from '@nuxtjs/composition-api';
import LazyHydrate from 'vue-lazy-hydration';
import { useCache, CacheTagPrefix } from '@vue-storefront/cache';
import { productGetters } from '~/getters';
import { useProduct } from '~/composables';
import MobileStoreBanner from '~/components/MobileStoreBanner.vue';
import InstagramFeed from '~/components/InstagramFeed.vue';
Expand All @@ -133,10 +133,7 @@ export default defineComponent({
const { addTags } = useCache();
const { app } = useContext();
const year = new Date().getFullYear();
const products = ref({});

const { getProductList, loading: newProductsLoading } = useProduct();

const heroes = ref([
{
title: app.i18n.t('Colorful summer dresses are already in store'),
Expand Down Expand Up @@ -243,20 +240,22 @@ export default defineComponent({
},
]);

// @ts-ignore
const newProducts = computed(() => productGetters.getFiltered(products.value?.items, { master: true }));

useFetch(async () => {
products.value = await getProductList({
const products = useAsync(async () => {
const productsData = await getProductList({
pageSize: 10,
currentPage: 1,
sort: {
position: 'ASC',
},
});

addTags([{ prefix: CacheTagPrefix.View, value: 'home' }]);
return productsData;
});

// @ts-ignore
const newProducts = computed(() => productGetters.getFiltered(products.value?.items, { master: true }));

return {
banners,
heroes,
Expand Down