Skip to content

Conversation

@Frodigo
Copy link
Contributor

@Frodigo Frodigo commented Mar 15, 2022

Description

  • refactored useRelatedProducts composable
  • refactored RelatedProducts component to use the useFetch instead of onSSR

Related Issue

M2-252

Motivation and Context

refactorizatio, improving performance and developer experience

How Has This Been Tested?

tested on my local environment

Screenshots (if appropriate):

Screenshot 2022-03-15 at 08 58 31

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo added this to the 1.0.0-rc.7 milestone Mar 15, 2022
@Frodigo Frodigo self-assigned this Mar 15, 2022
sethidden
sethidden previously approved these changes Mar 15, 2022
@Frodigo Frodigo force-pushed the refactor/M2-252-refactor-use-related-products branch from 7a90791 to e896c17 Compare March 15, 2022 12:09
@Frodigo Frodigo merged commit 85f06a3 into develop Mar 15, 2022
@Frodigo Frodigo deleted the refactor/M2-252-refactor-use-related-products branch March 15, 2022 12:51
@Frodigo Frodigo changed the title refactor: refactored usedRelatedProducts composable refactor!: refactored usedRelatedProducts composable Apr 27, 2022
Frodigo pushed a commit that referenced this pull request May 4, 2022
* refactor(relatedproducts): refactored usedRelatedProducts composable

* Update packages/composables/src/factories/useRelatedProductsFactory.ts

Co-authored-by: Bartosz Herba <[email protected]>

* Update packages/composables/src/composables/useRelatedProducts/index.ts

Co-authored-by: Bartosz Herba <[email protected]>

Co-authored-by: Bartosz Herba <[email protected]>
Frodigo pushed a commit that referenced this pull request May 4, 2022
* refactor(relatedproducts): refactored usedRelatedProducts composable

* Update packages/composables/src/factories/useRelatedProductsFactory.ts

Co-authored-by: Bartosz Herba <[email protected]>

* Update packages/composables/src/composables/useRelatedProducts/index.ts

Co-authored-by: Bartosz Herba <[email protected]>

Co-authored-by: Bartosz Herba <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants