Skip to content

Conversation

@aapokiiso
Copy link
Contributor

Description

The .env.example template for environment variables contained duplicates.
This caused some minor confusion when values had been set only to the first instances, and the duplicates overwrote them.

Related Issue

#723

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

The `.env.example` template for environment variables contained duplicates. 
This caused some minor confusion when values had been set only to the first instances, and the duplicates overwrote them.
Copy link
Contributor

@Frodigo Frodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aapokiiso

@Frodigo Frodigo changed the title Remove duplicate environment variables from template chore: remove duplicate environment variables from template Mar 14, 2022
@Frodigo Frodigo self-assigned this Mar 14, 2022
@Frodigo Frodigo merged commit ffaa427 into vuestorefront:develop Mar 14, 2022
@aapokiiso aapokiiso deleted the patch-1 branch March 14, 2022 15:35
@Frodigo Frodigo added this to the 1.0.0-rc.7 milestone Mar 15, 2022
Frodigo pushed a commit that referenced this pull request May 4, 2022
The `.env.example` template for environment variables contained duplicates. 
This caused some minor confusion when values had been set only to the first instances, and the duplicates overwrote them.
Frodigo pushed a commit that referenced this pull request May 4, 2022
The `.env.example` template for environment variables contained duplicates. 
This caused some minor confusion when values had been set only to the first instances, and the duplicates overwrote them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants