Skip to content

feat(theme): add our own styles for the default Magento Luma theme CMS blocks #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2022
Merged

feat(theme): add our own styles for the default Magento Luma theme CMS blocks #685

merged 1 commit into from
Mar 9, 2022

Conversation

@sethidden
Copy link
Contributor

@sethidden sethidden commented Mar 4, 2022 •
edited
Loading

Description

create previously missing styles for the Magneto Luma default CMS blocks

Related Issue

Motivation and Context

How Has This Been Tested?

Viewed the "Men" and "Women" category pages in the theme on mobile and desktop

Screenshots (if appropriate):

Now the Women's category looks like:
obraz

You can compare with https://magento2-instance.vuestorefront.io/women.html if you like

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sethidden
Copy link
Contributor Author

sethidden commented Mar 4, 2022 •
edited
Loading

  • Have to clean this up still

@sethidden sethidden force-pushed the bugfix/M2-219-add-styles-for-default-magento-cms-blocks branch 2 times, most recently from 16c1e49 to 16b4ef0 Compare March 4, 2022 13:28
@sethidden sethidden marked this pull request as ready for review March 4, 2022 13:30
bartoszherba
bartoszherba requested changes Mar 7, 2022
View reviewed changes
@sethidden sethidden force-pushed the bugfix/M2-219-add-styles-for-default-magento-cms-blocks branch 2 times, most recently from 3343d58 to 4e4b513 Compare March 7, 2022 14:00
@sethidden sethidden requested a review from bartoszherba March 7, 2022 14:00
@Frodigo
Copy link
Contributor

Frodigo commented Mar 8, 2022

Could you add a bigger margin between navigation and the first CMS banner?

Screenshot 2022-03-08 at 07 15 52

Frodigo
Frodigo suggested changes Mar 8, 2022
View reviewed changes
@sethidden sethidden force-pushed the bugfix/M2-219-add-styles-for-default-magento-cms-blocks branch from 4e4b513 to 626b1cb Compare March 8, 2022 06:24
@sethidden sethidden requested a review from Frodigo March 8, 2022 06:24
@Frodigo Frodigo self-requested a review March 8, 2022 07:22
Frodigo
Frodigo previously approved these changes Mar 8, 2022
View reviewed changes
@Frodigo
Copy link
Contributor

Frodigo commented Mar 8, 2022

@bartoszherba, can toy review again and approve if looks good?

bartoszherba
bartoszherba previously approved these changes Mar 8, 2022
View reviewed changes
@Frodigo
Copy link
Contributor

Frodigo commented Mar 8, 2022

@sethidden please resolve conflicts.

@sethidden
feat(theme): add our own styles for the default Magento Luma theme CM…
1879f34 
…S blocks

feat(theme): fix some luma's shortcomings

feat(theme): fix erin wrap

feat(theme): reduce button margin so it fits on men's category page

align img to the right
@sethidden sethidden dismissed stale reviews from bartoszherba and Frodigo via 1879f34 March 8, 2022 12:19
@sethidden sethidden force-pushed the bugfix/M2-219-add-styles-for-default-magento-cms-blocks branch from 626b1cb to 1879f34 Compare March 8, 2022 12:19
@sethidden sethidden requested a review from Frodigo March 8, 2022 12:19
@sethidden
Copy link
Contributor Author

sethidden commented Mar 8, 2022

Done. @Frodigo re-requested review

@Frodigo Frodigo merged commit 3cb3652 into develop Mar 9, 2022
@Frodigo Frodigo deleted the bugfix/M2-219-add-styles-for-default-magento-cms-blocks branch March 9, 2022 11:41
@Frodigo Frodigo added this to the 1.0.0-rc.7 milestone Mar 9, 2022
@Frodigo Frodigo mentioned this pull request May 10, 2022
Merged
@Frodigo Frodigo mentioned this pull request May 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoszherba bartoszherba bartoszherba left review comments

+1 more reviewer

@Frodigo Frodigo Frodigo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sethidden sethidden

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.7

Development

Successfully merging this pull request may close these issues.

4 participants

@sethidden @Frodigo @bartoszherba