fix(theme): wishlist sidebar "sad green box" image is not centered vertically (when wishlist empty) #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is not based on any Figma designs - just aligning `WishlistSidebar.vue` with `CartSidebar.vue` This is a fix ONLY for the desktop version. There's still a few px of vertical difference between the `<SvgImages>` on mobile CartSidebar and mobile WishlistSidebar, but that's because one of them has a text header and the other doesn't (separate issue)
sethidden
changed the title
sethidden
changed the title
Frodigo
approved these changes
Mar 2, 2022
Frodigo
deleted the
bugfix/M2-211-wishlist-your-bag-is-empty-is-not-centered
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Centered the
<SvgImage>depicting the "sad green box" in the WishlistSidebar. Basically just aligned with what's in CartSidebar (this is not based on some Figma designs on anything)This aligns only the desktop version. The wishlist on mobile has double "My wishlist" text (in sidebar header and in the sidebar itself), so the vertical position of the "sad green box" image is off by a few px between the mobile sidebar and mobile wishlist. I deemed it a separate issue so I didn't change that.
Types of changes
Checklist: