Skip to content

refactor: move search form to separate component #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2022
Merged

refactor: move search form to separate component #642

merged 1 commit into from
Feb 22, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Feb 22, 2022 •
edited
Loading

Description

  • move search bar component to components/Header
  • remove unused code and watchers

Related Issue

Motivation and Context

refactoring

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba
refactor(theme): refactor SearchBar component
908b5df 
- move search bar component to components/Header
- remove unused code and watchers
@bartoszherba bartoszherba requested a review from Frodigo February 22, 2022 08:41
@Frodigo Frodigo changed the title M2-186. Move search form to separate component refactor: M2-186. Move search form to separate component Feb 22, 2022
@Frodigo Frodigo changed the title refactor: M2-186. Move search form to separate component refactor: move search form to separate component Feb 22, 2022
@Frodigo Frodigo merged commit 659db4e into develop Feb 22, 2022
@Frodigo Frodigo deleted the M2-186-move-search-form-to-separate-component branch February 22, 2022 08:59
This was referenced Mar 8, 2022
Merged
Merged
@bartoszherba bartoszherba restored the M2-186-move-search-form-to-separate-component branch April 11, 2022 06:49
@Frodigo Frodigo deleted the M2-186-move-search-form-to-separate-component branch April 20, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Frodigo Frodigo Frodigo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Frodigo Frodigo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszherba @Frodigo