Skip to content

refactor(theme): made top bar graphql requests non-blocking #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2022
Merged

refactor(theme): made top bar graphql requests non-blocking #621

merged 1 commit into from
Feb 24, 2022

Conversation

@Frodigo
Copy link
Contributor

@Frodigo Frodigo commented Feb 18, 2022

Description

  • made TopBar lazy-loaded
  • remove async/await in useTopBar to unblock main thread working

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo added this to the Stable 1.0.0 release milestone Feb 18, 2022
bartoszherba
bartoszherba reviewed Feb 21, 2022
View reviewed changes
@Frodigo Frodigo force-pushed the refactor/M2-179-make-the-top-bar-component-lazy-loaded branch from 459c809 to 43307f6 Compare February 24, 2022 10:25
@Frodigo Frodigo changed the title refactor(theme): made TopBar component lazy loaded refactor(theme): made top bar graphql requests non-blocking Feb 24, 2022
@Frodigo Frodigo requested a review from bartoszherba February 24, 2022 10:34
@Frodigo Frodigo merged commit 8a4b1d5 into develop Feb 24, 2022
@Frodigo Frodigo deleted the refactor/M2-179-make-the-top-bar-component-lazy-loaded branch February 24, 2022 11:10
This was referenced Mar 8, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartoszherba bartoszherba bartoszherba approved these changes

@KevinGorjan KevinGorjan Awaiting requested review from KevinGorjan

Assignees

@Frodigo Frodigo

Labels

None yet

Projects

None yet

Milestone

1.0.0-rc.6

Development

Successfully merging this pull request may close these issues.

3 participants

@Frodigo @bartoszherba