Skip to content

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Feb 1, 2022

Description

useFacets composable was ignoring customQueries, here is the fix for that

Related Issue

#533

Motivation and Context

bugfix

How Has This Been Tested?

  • add custom query for products and check if data returned on the category page includes custom fields

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba requested a review from Frodigo February 1, 2022 13:52
@Frodigo Frodigo changed the base branch from develop to release/1.0.0-rc.5.4 February 2, 2022 08:18
@Frodigo Frodigo changed the base branch from release/1.0.0-rc.5.4 to develop February 2, 2022 08:18
@Frodigo Frodigo added this to the RC-5.4 milestone Feb 2, 2022
@Frodigo Frodigo merged commit 3c7790f into develop Feb 2, 2022
@Frodigo Frodigo deleted the M2-137-bug-use-facets-composable-ignores-custom-queries branch February 2, 2022 08:21
@bartoszherba bartoszherba restored the M2-137-bug-use-facets-composable-ignores-custom-queries branch April 11, 2022 06:49
@Frodigo Frodigo deleted the M2-137-bug-use-facets-composable-ignores-custom-queries branch April 20, 2022 04:36
@bartoszherba bartoszherba mentioned this pull request Apr 25, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants