Skip to content

fix(theme): update login modal to handle translations #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2022
Merged

fix(theme): update login modal to handle translations #521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions packages/theme/components/LoginModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
v-model="form.username"
v-e2e="'login-modal-email'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="email"
:label="$t('Your email')"
class="form__element"
Expand All @@ -48,7 +48,7 @@
v-model="form.password"
v-e2e="'login-modal-password'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="password"
:label="$t('Password')"
type="password"
Expand All @@ -58,7 +58,7 @@
</ValidationProvider>
<recaptcha v-if="isRecaptchaEnabled" />
<div v-if="error.login">
{{ error.login }}
{{ $t(error.login) }}
</div>
<SfButton
v-e2e="'login-modal-submit'"
Expand Down Expand Up @@ -113,7 +113,7 @@
v-model="form.username"
v-e2e="'forgot-modal-email'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="email"
:label="$t('Forgot Password Modal Email')"
class="form__element"
Expand Down Expand Up @@ -175,7 +175,7 @@
v-model="form.email"
v-e2e="'login-modal-email'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="email"
:label="$t('Your email')"
class="form__element"
Expand All @@ -189,7 +189,7 @@
v-model="form.firstName"
v-e2e="'login-modal-firstName'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="first-name"
:label="$t('First Name')"
class="form__element"
Expand All @@ -203,7 +203,7 @@
v-model="form.lastName"
v-e2e="'login-modal-lastName'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="last-name"
:label="$t('Last Name')"
class="form__element"
Expand All @@ -217,7 +217,7 @@
v-model="form.password"
v-e2e="'login-modal-password'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="password"
:label="$t('Password')"
type="password"
Expand All @@ -240,15 +240,15 @@
v-model="createAccount"
v-e2e="'login-modal-create-account'"
:valid="!errors[0]"
:error-message="errors[0]"
:error-message="$t(errors[0])"
name="create-account"
:label="$t('I want to create an account')"
class="form__element"
/>
</ValidationProvider>
<recaptcha v-if="isRecaptchaEnabled" />
<div v-if="error.register">
{{ error.register }}
{{ $t(error.register) }}
</div>
<SfButton
v-e2e="'login-modal-submit'"
Expand Down
5 changes: 4 additions & 1 deletion packages/theme/lang/de.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,5 +183,8 @@ export default {
"Your bag is empty": "Ihre Tasche ist leer",
"Your current email address is": "Ihre aktuelle E-Mail-Adresse lautet",
"Your email": "Deine E-Mail",
'You have submitted no reviews': 'Sie haben keine Bewertungen abgegeben',
"You have submitted no reviews": "Sie haben keine Bewertungen abgegeben",
"The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later.":"Die Kontoanmeldung war falsch oder Ihr Konto wurde vorübergehend deaktiviert. Bitte warten Sie und versuchen Sie es später erneut.",
"A customer with the same email address already exists in an associated website.": "Ein Kunde mit derselben E-Mail-Adresse existiert bereits auf einer verknüpften Website.",
"Invalid email": "Ungültige E-Mail"
};
5 changes: 4 additions & 1 deletion packages/theme/lang/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,12 @@ export default {
"You are not authorized, please log in": "You are not authorized, please log in",
"You can unsubscribe at any time": "You can unsubscribe at any time",
"You currently have no orders": "You currently have no orders",
"You haven’t searched for items yet": "You haven’t searched for items yet.",
"You haven\’t searched for items yet": "You haven’t searched for items yet.",
"Your bag is empty": "Your bag is empty",
"Your current email address is": "Your current email address is",
"Your email": "Your email",
'You have submitted no reviews': 'You have submitted no reviews',
"The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later.":"The account sign-in was incorrect or your account is disabled temporarily. Please wait and try again later.",
"A customer with the same email address already exists in an associated website.": "A customer with the same email address already exists in an associated website.",
"Invalid email": "Invalid email"
};