Skip to content

fix(theme): fix footer lazy hydration #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix(theme): fix footer lazy hydration #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/theme/layouts/default.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,13 @@
<TopBar class="desktop-only" />
</LazyHydrate>

<LazyHydrate when-visible>
<AppHeader />
</LazyHydrate>
<AppHeader />

<div id="layout">
<nuxt :key="route.fullPath" />
</div>

<LazyHydrate on-interaction>
<LazyHydrate when-visible>
<BottomNavigation />
</LazyHydrate>
<LazyHydrate when-idle>
Expand All @@ -27,7 +25,7 @@
<LazyHydrate when-idle>
<Notification />
</LazyHydrate>
<LazyHydrate on-interaction>
<LazyHydrate when-visible>
<AppFooter />
</LazyHydrate>
</div>
Expand All @@ -41,13 +39,13 @@ import {
} from '@vue-storefront/magento';
import AppHeader from '~/components/AppHeader.vue';
import BottomNavigation from '~/components/BottomNavigation.vue';
import AppFooter from '~/components/AppFooter.vue';
import TopBar from '~/components/TopBar.vue';
import CartSidebar from '~/components/CartSidebar.vue';
import WishlistSidebar from '~/components/WishlistSidebar.vue';
import LoginModal from '~/components/LoginModal.vue';
import Notification from '~/components/Notification';
import { useMagentoConfiguration } from '~/composables/useMagentoConfiguration';
import Notification from '~/components/Notification';
import AppFooter from '~/components/AppFooter.vue';

export default defineComponent({
name: 'DefaultLayout',
Expand Down