Skip to content

fix(theme): add debounced update quantity action so it will be possib… #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022
Merged

fix(theme): add debounced update quantity action so it will be possib… #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/theme/components/CartSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@
)
"
class="collected-product"
@input="updateItemQty({ product, quantity: $event })"
@input="delayedUpdateItemQty({ product, quantity: $event })"
@click:remove="sendToRemove({ product })"
>
<template #input>
Expand All @@ -125,7 +125,7 @@
:disabled="loading"
:qty="cartGetters.getItemQty(product)"
class="sf-collected-product__quantity-selector"
@input="updateItemQty({ product, quantity: $event })"
@input="delayedUpdateItemQty({ product, quantity: $event })"
/>
</div>
<SfBadge
Expand Down Expand Up @@ -257,9 +257,10 @@ import {
cartGetters,
useExternalCheckout,
} from '@vue-storefront/magento';
import _debounce from 'lodash.debounce';
import { useUiState, useUiNotification } from '~/composables';
import CouponCode from './CouponCode.vue';
import stockStatusEnum from '~/enums/stockStatusEnum';
import CouponCode from './CouponCode.vue';

export default defineComponent({
name: 'CartSidebar',
Expand Down Expand Up @@ -342,7 +343,7 @@ export default defineComponent({
title: 'Product removed',
});
};

const delayedUpdateItemQty = _debounce((params) => updateItemQty(params), 1000);
const isInStock = (product) => cartGetters.getStockStatus(product) === stockStatusEnum.inStock;

return {
Expand All @@ -352,7 +353,7 @@ export default defineComponent({
isAuthenticated,
products,
removeItem,
updateItemQty,
delayedUpdateItemQty,
isCartSidebarOpen,
notifications,
visible,
Expand Down