-
Notifications
You must be signed in to change notification settings - Fork 116
fix: handle currency switch issue #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6390f87
fix(theme): solve currency change issue
bartoszherba 24ddc54
docs(theme): add currency formatting plugin information
bartoszherba 6ffd506
test(theme): add UT for plugin and formatCurrency helper
bartoszherba 0e6d985
refactor(fcplugin): change the logic responsible for resolving locale…
bartoszherba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import formatCurrency from '~/helpers/formatCurrency'; | ||
|
|
||
| describe('formatCurrency()', () => { | ||
| it('executed without required options should throw error', () => { | ||
| expect(() => { formatCurrency(100, 'en-US', {}); }).toThrowError(); | ||
| }); | ||
|
|
||
| it('should return formatted currency string', () => { | ||
| const currency = 'EUR'; | ||
| jest.spyOn(Intl, 'NumberFormat').mockImplementation(() => ({ | ||
| format: (value) => `${value}${currency}`, | ||
| })); | ||
| const result = formatCurrency(123, 'de-DE', { currency }); | ||
| expect(result).toBe('123EUR'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| const formatCurrency = (value: number | string, locale: string, options: Intl.NumberFormatOptions): string => { | ||
| if (typeof value === 'string') { | ||
| // eslint-disable-next-line no-param-reassign | ||
| value = Number(value); | ||
| } | ||
| // eslint-disable-next-line no-param-reassign | ||
|
|
||
| return new Intl.NumberFormat(locale, { style: 'currency', ...options }).format(value); | ||
| }; | ||
|
|
||
| export default formatCurrency; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import fcPlugin from '~/plugins/fcPlugin'; | ||
|
|
||
| const injectFnMock = jest.fn(); | ||
|
|
||
| describe('Format currency plugin', () => { | ||
| it('should inject $fc', () => { | ||
| fcPlugin({ app: {} }, injectFnMock); | ||
| expect(injectFnMock).toHaveBeenCalledTimes(1); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import cookieNames from '~/enums/cookieNameEnum'; | ||
| import formatCurrency from '~/helpers/formatCurrency'; | ||
|
|
||
| declare module 'vue/types/vue' { | ||
| interface Vue { | ||
| $fc(value: number | string): string; | ||
| $fc(value: number | string, options?: Intl.NumberFormatOptions): string; | ||
| $fc(value: number | string, locale?: string, options?: Intl.NumberFormatOptions): string; | ||
| } | ||
| } | ||
|
|
||
| export default ({ app }, inject) => { | ||
| inject('fc', (value: number | string, locale?: string, options = {}): string => { | ||
| // eslint-disable-next-line no-param-reassign | ||
| locale = locale || app.i18n?.localeProperties?.iso.replace('_', '-'); | ||
| // eslint-disable-next-line no-param-reassign | ||
| options = { currency: app.$cookies.get(cookieNames.currencyCookieName), ...options }; | ||
|
|
||
| return formatCurrency(value, locale, options); | ||
| }); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.