Skip to content

fix(theme): fix preselection of sort order when query param is available #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022
Merged

fix(theme): fix preselection of sort order when query param is available #385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/theme/pages/Category.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@

<div class="navbar__sort desktop-only">
<span class="navbar__label">{{ $t('Sort by') }}:</span>
<LazyHydrate on-interaction>
<LazyHydrate when-visible>
<SfSelect
:value="sortBy.selected"
placeholder="Select sorting"
Expand Down Expand Up @@ -90,7 +90,7 @@
<div class="main section">
<div class="sidebar desktop-only">
<LazyHydrate when-visible>
<CategorySidebarMenu
<category-sidebar-menu
:no-fetch="true"
/>
</LazyHydrate>
Expand Down Expand Up @@ -371,6 +371,7 @@ import { useAddToCart } from '~/helpers/cart/addToCart';

// TODO(addToCart qty, horizontal): https://github.com/vuestorefront/storefront-ui/issues/1606
export default defineComponent({
name: 'CategoryPage',
components: {
CategorySidebarMenu,
SfButton,
Expand Down