fix: product list page items on product page list page zero prices issues #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
jeffpdotone
reviewed
Oct 12, 2022
| ...product, | ||
| price_range: priceData.items.find((item) => item.sku === product.sku)?.price_range, | ||
| })); | ||
| products.value = products.value.map((product) => { |
Contributor
There was a problem hiding this comment.
I believe mapping could be better if handled in the server-side instead of this kind.
But if it's really needed perhaps, we could extract them to a helper function or something similar.
Collaborator
Author
There was a problem hiding this comment.
It can't be done on the server because it must bypass the cache including Redis or CDN, that is why it is executed in the onMounted hook otherwise, prices will be cached.
bartoszherba
deleted the
IN-386-product-list-page-items-on-product-list-page-are-displayed-as-having-price-0
branch
This was referenced Oct 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How Has This Been Tested?
or simply jump between Gear and Man categories.
Screenshots (if appropriate):
Types of changes
Checklist: