Skip to content

Conversation

@Frodigo
Copy link
Contributor

@Frodigo Frodigo commented Oct 8, 2022

Description

Once we remove graphql-request and do not send requests to Magento directly from the front end, we can remove information about CORS configuration from the installation guide.

Motivation and Context

Keep docs up to date

How Has This Been Tested?

I tested docs on my local

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo requested a review from a team as a code owner October 8, 2022 09:06
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bartoszherba bartoszherba added this to the 1.1.0 milestone Oct 12, 2022
@bartoszherba bartoszherba self-assigned this Oct 12, 2022
@bartoszherba bartoszherba merged commit d25560e into main Oct 12, 2022
@bartoszherba bartoszherba deleted the docs/remove-cors-from-installation-guide branch October 12, 2022 06:25
@bartoszherba bartoszherba restored the docs/remove-cors-from-installation-guide branch October 12, 2022 06:28
@bloodf bloodf deleted the docs/remove-cors-from-installation-guide branch December 5, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants