Skip to content

fix: update CDN default configuration #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix: update CDN default configuration #1372

merged 1 commit into from
Oct 12, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Oct 6, 2022 •
edited
Loading

Description

Checkout - CDN is serving cached data for checkout

  • exclude /customer, /checkout paths from being cached in the CDN

How Has This Been Tested?

Cache headers were validated on the customer account and the checkout

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba
fix: update CDN default configuration
af21f77 
- exclude */customer*, */checkout* paths from being cached in the CDN
@bartoszherba bartoszherba requested a review from a team October 6, 2022 06:00
@bartoszherba bartoszherba requested a review from Frodigo as a code owner October 6, 2022 06:00
@bartoszherba bartoszherba removed the request for review from Frodigo October 6, 2022 06:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bartoszherba bartoszherba self-assigned this Oct 6, 2022
@bartoszherba bartoszherba added this to the 1.1.0 milestone Oct 6, 2022
@bartoszherba bartoszherba merged commit 79e5ed5 into release/1.1.0 Oct 12, 2022
@bartoszherba bartoszherba deleted the fix/cdn-misconfiguration branch October 12, 2022 07:38
This was referenced Oct 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffpdotone jeffpdotone jeffpdotone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bartoszherba bartoszherba

Labels

None yet

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszherba @jeffpdotone