fix: pods does not get up after deployment #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
force-pushed
the
fix/add-ssr-middleware-url
branch
from
2fd6b81 to
c9a2c5d
Compare
Frodigo
suggested changes
Aug 31, 2022
Contributor
Frodigo
left a comment
Frodigo
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
Can you update documentation and explain what ssrMiddlewareUrl variable is?
bartoszherba
force-pushed
the
fix/add-ssr-middleware-url
branch
2 times, most recently
from
bf9f966 to
79d0e76
Compare
bartoszherba
force-pushed
the
fix/add-ssr-middleware-url
branch
from
79d0e76 to
7e9e6fc
Compare
- add ssrMiddlewareUrl to prevent make a call to unavailable external client
bartoszherba
force-pushed
the
fix/add-ssr-middleware-url
branch
from
7e9e6fc to
0883ddf
Compare
Frodigo
approved these changes
Sep 2, 2022
Frodigo
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's SSR <--> API implementation issue when it comes to deployment using a rolling-update strategy. During the deployment, the Kubernetes is probing SSR if it's already up. SSR is trying to call middleware using an external URL (market...storefrontcloud. io) rather than localhost:3000/API, while the middleware isn't available publicly yet, because the SSR didn't respond with 200 in the first place. The workaround works because it allows the project to be deployed and make the API available, and later we fix the SSR to use the remote API address back again
Types of changes
Checklist: