Skip to content

fix: add missing canary url protocols #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2022
Merged

fix: add missing canary url protocols #1349

merged 1 commit into from
Sep 1, 2022

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Aug 31, 2022 •
edited
Loading

Description

add missing canary url prtocols

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba requested a review from Frodigo as a code owner August 31, 2022 11:27
@bartoszherba bartoszherba changed the title fix: add missing canary url prtocols fix: add missing canary url protocols Sep 1, 2022
@bartoszherba bartoszherba merged commit 2af8148 into develop Sep 1, 2022
@bartoszherba bartoszherba deleted the fix/add-missing-canary-urls-protocol branch September 1, 2022 08:23
@Frodigo Frodigo added this to the 1.1.0 milestone Sep 5, 2022
@Frodigo Frodigo mentioned this pull request Sep 5, 2022
Merged
@bartoszherba bartoszherba mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Frodigo Frodigo Frodigo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bartoszherba @Frodigo