fix: logout doesn't work after reload of the MyAccount page #1347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
force-pushed
the
M2-1017-my-account-logout-doesnt-work-after-page-refresh
branch
from
570c273 to
bf79b8f
Compare
bartoszherba
force-pushed
the
M2-1017-my-account-logout-doesnt-work-after-page-refresh
branch
from
bf79b8f to
e941c0d
Compare
bartoszherba
commented
Sep 1, 2022
| { | ||
| id: 'log-out', | ||
| label: 'Log out', | ||
| listeners: { |
Collaborator
Author
There was a problem hiding this comment.
Unfortunately, if the component returns an object with a function inside, that function will be removed on the SRR, probably due to the serialization of the response. Only functions returned without containers are returned as expected.
Frodigo
approved these changes
Sep 2, 2022
bartoszherba
deleted the
M2-1017-my-account-logout-doesnt-work-after-page-refresh
branch
Frodigo
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Logout should work always, also after page refresh during browsing "My Account".
How Has This Been Tested?
Open Magento 2 e-commerce integration page.
2. Login using valid credentials.
3. Move the mouse to the "User Account" icon in the top menu bar and click it.
4. Refresh the page.
5. Move the mouse to "Logout" in the left column and click it.
Screenshots (if appropriate):
Types of changes
Checklist: