feat: add i18n base url configuration #1314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set baseUrl to env variable
|
Kudos, SonarCloud Quality Gate passed!
|
|
@bartoszherba Thank you for this PR. Appriciate the Talk over Discord and quick action about this topic |
sethidden
approved these changes
Jul 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
i18n is responsible for basic SEO optimization including canonical URLs, it can be configured manually but I added VSF_STORE_ENV as a base URL which will be a good OOB solution for most projects.
Motivation and Context
Improvement
Types of changes
Checklist: