Skip to content

ci: stop using personal access token for deployment api #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022
Merged

ci: stop using personal access token for deployment api #1303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions .github/workflows/deploy-vue-storefront-cloud.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ on:
jobs:
create-deployment:
runs-on: ubuntu-latest

permissions:
deployments: write

outputs:
environment-name: ${{ steps.determine-environment.outputs.name }}
environment-code: ${{ steps.determine-environment.outputs.code }}
Expand Down Expand Up @@ -55,7 +59,7 @@ jobs:
id: deployment
uses: chrnorm/deployment-action@v2
with:
token: ${{ secrets.DEPLOYMENT_PERSONAL_ACCESS_TOKEN }}
token: ${{ github.token }}
environment: ${{ steps.determine-environment.outputs.name }}
initial-status: in_progress
build:
Expand Down Expand Up @@ -130,21 +134,25 @@ jobs:

finalize-deployment:
runs-on: ubuntu-latest

permissions:
deployments: write

needs: [create-deployment, build, deploy]
if: always()
steps:
- name: Update deployment status (success)
if: ${{ !(contains(join(needs.*.result, ','), 'failure') || contains(join(needs.*.result, ','), 'cancelled')) }}
uses: chrnorm/deployment-status@v2
with:
token: ${{ secrets.DEPLOYMENT_PERSONAL_ACCESS_TOKEN }}
token: ${{ github.token }}
deployment-id: ${{ needs.create-deployment.outputs.deployment_id }}
state: success

- name: Update deployment status (failure)
if: ${{ contains(join(needs.*.result, ','), 'failure') || contains(join(needs.*.result, ','), 'cancelled') }}
uses: chrnorm/deployment-status@v2
with:
token: ${{ secrets.DEPLOYMENT_PERSONAL_ACCESS_TOKEN }}
token: ${{ github.token }}
deployment-id: ${{ needs.create-deployment.outputs.deployment_id }}
state: failure