Skip to content

Conversation

@bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jul 21, 2022

Description

  • lock dependencies on the last working version to avoid upgrade issues

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- lock dependencies on the last working version to avoid upgrade issues
Comment on lines +64 to +65
"vue-server-renderer": "2.6.14",
"vue-template-compiler": "2.6.14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this wasn't here before those are probably dependencies of vue itself, so if vue is 2.6.14 they should be 2.6.14 aswell.
I know they were in my yarn add magic command on Slack but they more fixed the yarn lock than being strictly necessary.

I'm accepting the PR either way

Copy link
Contributor

@sethidden sethidden Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually deps of nuxt vue-renderer, so perhaps the issue is in some more top-level backage while here we're trying to solve it bottom-up
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't work witwithout this, because yarn installed [email protected]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it probably didn't work without this because another package is installing the too-new version (in this case @nuxt/vue-renderer)

@Frodigo Frodigo added this to the 1.0.1 milestone Jul 21, 2022
@sethidden sethidden mentioned this pull request Jul 21, 2022
9 tasks
@Frodigo Frodigo merged commit 2e7912f into develop Jul 21, 2022
@Frodigo Frodigo deleted the fix/vue-dependencies-update branch July 21, 2022 12:37
@Frodigo Frodigo mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants