ci: refactor k6 action to add new env vars #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
force-pushed
the
M2-1033-refactor-k6-action
branch
2 times, most recently
from
7edc574 to
d50202e
Compare
sethidden
force-pushed
the
M2-1033-refactor-k6-action
branch
from
d50202e to
defa606
Compare
sethidden
changed the title
sethidden
force-pushed
the
M2-1033-refactor-k6-action
branch
from
defa606 to
9f00919
Compare
sethidden
commented
Jul 21, 2022
| echo ::set-output name=name::$ENVNAME | ||
| echo ::set-output name=code::$ENVCODE | ||
| echo ::set-output name=middleware-url::$MIDDLEWARE_URL | ||
| cat .github/workflows/public_env_info/$ENVINFO_FILE >> $GITHUB_ENV |
Contributor
Author
There was a problem hiding this comment.
environment-related env vars are now kept in separate files. Had I not done that, env info would be duplicated in the k6 action and in our regular deploy to Farmer action. It'd be more difficult to maintain
sethidden
force-pushed
the
M2-1033-refactor-k6-action
branch
from
9f00919 to
c77fddb
Compare
bartoszherba
approved these changes
Jul 22, 2022
Contributor
Author
|
@bartoszherba this PR is targeting the main branch because workflows that are meant to be ran manually take source code from the repo's designated primary branch (main in our case) |
|
Kudos, SonarCloud Quality Gate passed!
|
Frodigo
approved these changes
Aug 2, 2022
update k6 action to select environments instead of urls, because with K6 we'll probably need 3 separate urls (middleware, frontend app and graphql endpoint) which would be painful to type in manually now you just input the env name and it selects the 3 urls on its own M2-1033 ci: update k6 script with new variables ci: update envs with new naming convention
Frodigo
force-pushed
the
M2-1033-refactor-k6-action
branch
from
c77fddb to
2061aae
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change K6 action so that it works by picking the environment rather than specifying the url. Our upcoming implementation of load tests will have three separate urls (magento instance, middleware url, frontend url). Specifying each url by hand/adding it to the url dropdown would be annoying