Skip to content

fix: button add to cart doesn't work for configurable products #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix: button add to cart doesn't work for configurable products #1208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions packages/theme/modules/catalog/pages/product.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,16 +102,22 @@ export default defineComponent({
// eslint-disable-next-line no-underscore-dangle
const renderer = computed(() => product.value?.__typename ?? ProductTypeEnum.SIMPLE_PRODUCT);

const fetchProduct = async (searchQuery = getBaseSearchQuery()) => {
const fetchProductBaseData = async (searchQuery = getBaseSearchQuery()) => {
const result = await getProductDetails({
...searchQuery,
});

product.value = merge({}, product.value, result.items[0] as Product ?? null);
};

const fetchProductExtendedData = async (searchQuery = getBaseSearchQuery()) => {
const { data } = await query<ProductDetailsQuery>(getProductPriceBySkuGql, searchQuery);

product.value = merge({}, product.value, data.products?.items?.[0] as Product);
};

useFetch(async () => {
await fetchProduct();
await fetchProductBaseData();

if (Boolean(product?.value?.sku) === false) nuxtError({ statusCode: 404 });

Expand All @@ -131,18 +137,14 @@ export default defineComponent({
addTags([...tags, ...productTags]);
});

onMounted(async () => {
const { data } = await query<ProductDetailsQuery>(getProductPriceBySkuGql, getBaseSearchQuery());

product.value = merge({}, product.value, data.products?.items?.[0] as Product);
});
onMounted(async () => fetchProductExtendedData());

return {
renderer,
loading,
breadcrumbs,
product,
fetchProduct,
fetchProduct: fetchProductExtendedData,
};
},
});
Expand Down