perf: category page CLS improvement #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
commented
Jun 29, 2022
| @@ -1,10 +1,5 @@ | |||
| <template> | |||
| <transition-group | |||
Collaborator
Author
There was a problem hiding this comment.
This is to prevent opacity, transition issue reports
| right: 0; | ||
| ::v-deep .sf-product-card { | ||
| &__image-wrapper { | ||
| height: 257px; |
Collaborator
Author
There was a problem hiding this comment.
Because of the lack of control over SFUI components, I had to take some space to prevent content jump.
Frodigo
suggested changes
Jun 29, 2022
Contributor
Frodigo
left a comment
Frodigo
left a comment
There was a problem hiding this comment.
I need more time to analyze and review this. I will back to you with comments later.
- improve title loading - improve filters cls and content jumps
bartoszherba
force-pushed
the
M2-836-category-page-cumulative-layout-shift-in-both-desktop-and-mobile-browsers
branch
from
b36467e to
a56410d
Compare
Frodigo
approved these changes
Jun 30, 2022
Frodigo
deleted the
M2-836-category-page-cumulative-layout-shift-in-both-desktop-and-mobile-browsers
branch
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
category page CLS improvement
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: