fix: merging cart doesn't work for bundled products #1176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartoszherba
changed the title
bartoszherba
approved these changes
Jun 28, 2022
Frodigo
deleted the
M2-861-cart-merging-carts-doesnt-work-for-bundled-products
branch
Frodigo
changed the title
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the App crashed during merging carts with bundled products.
This is caused by an internal error in Magento 2.4.3 and 2.4.4.
On the Magento 2.4-dev branch, it works as well so probably it will work in Magento 2.4.5
For now, I just handled errors thrown by mergeCarts mutation.
After this PR it's possible to log in when you have bundled product in the cart. The app doesn't crash anymore.